extract_features_from_genbank uses isolate as strain id, if strain is…#123
Open
vinuesa wants to merge 1 commit into
Open
extract_features_from_genbank uses isolate as strain id, if strain is…#123vinuesa wants to merge 1 commit into
vinuesa wants to merge 1 commit into
Conversation
Owner
|
Thanks @vinuesa , I guess should be simply Can you please propagate this change to all extract_*_from_genbank subs? |
Collaborator
Author
|
Hi @eead-csic-compbio, the proposed code snippet avoids overwriting the strain qualifier in the few cases when both strain and isolate are defined in the GenBank file, which can differ, resulting in the isolate tag being assigned to strain. What do you think? |
Owner
|
Hola @vinuesa , then I guess it should be something like this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_features_from_genbank in phyTools.pm now uses isolate as a strain ID if the strain attribute is undefined.